Skip to content

[PR #2219/c81d7440 backport][2.26] Fix monolithic push memory issues#2253

Merged
ggainey merged 2 commits into2.26from
patchback/backports/2.26/c81d74400d54c5c4596212f2092445ad24ebcbac/pr-2219
Mar 9, 2026
Merged

[PR #2219/c81d7440 backport][2.26] Fix monolithic push memory issues#2253
ggainey merged 2 commits into2.26from
patchback/backports/2.26/c81d74400d54c5c4596212f2092445ad24ebcbac/pr-2219

Conversation

@patchback
Copy link
Copy Markdown

@patchback patchback Bot commented Mar 9, 2026

This is a backport of PR #2219 as merged into main (c81d744).

According to the spec there are two ways to perform monolithic blob pushes:

  1. On the initial POST request with the digest query parameter
  2. Empty (normal) body POST, then all in the PUT

There's an unofficial third way that podman can apparently do according to our comments which is:

  1. Normal empty POST
  2. Entire chunk in one PATCH with no Range header
  3. Empty PUT

The code should now call our special large chunk handler for all three cases, we were forgetting case number 2. Note that depending on the client they could still cause the server to go OOM if they send ridiculously large chunks in the normal chunked upload path since we read the entire chunk into memory before saving it. There is nothing we can do here as part of the code lives in pulpcore, but honestly what is that client thinking sending such large chunks!

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

(cherry picked from commit c81d744)
@patchback patchback Bot mentioned this pull request Mar 9, 2026
4 tasks
@ggainey ggainey merged commit 72fac7a into 2.26 Mar 9, 2026
13 checks passed
@ggainey ggainey deleted the patchback/backports/2.26/c81d74400d54c5c4596212f2092445ad24ebcbac/pr-2219 branch March 9, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants