This repository was archived by the owner on Jan 15, 2025. It is now read-only.
1034978 - Add visible errors to unit associate & unassociate commands#94
Merged
barnabycourt merged 3 commits intomasterfrom Jan 2, 2014
Merged
1034978 - Add visible errors to unit associate & unassociate commands#94barnabycourt merged 3 commits intomasterfrom
barnabycourt merged 3 commits intomasterfrom
Conversation
…the base class in pulp
Contributor
There was a problem hiding this comment.
I don't think we are supposed to update Copyright dates in our code. I can't remember for sure, but I think it might be important to retain the original date. Anybody else know for sure?
Contributor
|
Looks good to me, though I think we should find out for sure about whether or not it's OK to change the copyright dates. As for my suggestions about writing that method once, do whatever your preference is. Merge on. |
ghost
assigned
barnabycourt
added a commit
that referenced
this pull request
Jan 2, 2014
1034978 - Add visible errors to unit associate & unassociate commands
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
BZ: https://bugzilla.redhat.com/show_bug.cgi?id=1034978