First fix for pip install issue #6792#273
Merged
dkliban merged 1 commit intopulp:masterfrom May 22, 2020
Merged
Conversation
Contributor
Author
|
This should be the second fix required to close #6792: pulp/pulpcore#715 |
dkliban
reviewed
May 22, 2020
| @@ -0,0 +1 @@ | |||
| Added "index.html/" to the relative_path field for both project_metadata and index_metadata. | |||
Member
There was a problem hiding this comment.
it's index.html without the trailing '/'
…t metadata that was causing the pulp contentapp to incorrectly render the wrong html. Fixed generated links in simple_index_template. fixes #6792 https://pulp.plan.io/issues/6792
Member
|
I manually test this and it works! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed published metadata relative_path names for the index and project metadata that was causing the pulp contentapp to incorrectly render the wrong html.
Contentapp still incorrectly sets the html's headers causing pip install to fail with the following:
ref #6792
https://pulp.plan.io/issues/6792