Sync default policy is on_demand. #313
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gerrod3
force-pushed
the
default_ondemand
branch
from
f041351 to
d67b9c6
Compare
dralley
approved these changes
Oct 8, 2020
dralley
reviewed
Oct 8, 2020
CHANGES/7401.misc
Outdated
| @@ -0,0 +1 @@ | |||
| Syncing defaults to policy 'on_demand' now. | |||
Contributor
There was a problem hiding this comment.
Change the default download policy to 'on_demand', as bulk syncs of PyPI would use several terabytes of disk space.
Contributor
There was a problem hiding this comment.
You don't have to use that ^ but a little more detail would be helpful I think.
Also, we should fix the http responses on this page [0], and flesh out the documentation to cover the following:
- An example of a full-pypi mirror and a note about the changed default from what is typical with Pulp, and why (terabytes of disk needed)
- Fix the includes / excludes specifiers since I think they are still using the "old" format - looks like the existing PR has no response still
- Note that you do a full-pypi mirror by simply not using the "includes" field
[0] https://github.com/pulp/pulp_python/blob/master/docs/workflows/sync.rst#create-a-remote
Contributor
There was a problem hiding this comment.
Not sure if this got hidden by the "outdated" but it's still applicable.
gerrod3
force-pushed
the
default_ondemand
branch
from
d67b9c6 to
2ab81cb
Compare
gerrod3
force-pushed
the
default_ondemand
branch
from
2ab81cb to
3834110
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes: #7401
https://pulp.plan.io/issues/7401