Skip to content

Allow batch size of artifacts processed during sync to be configured#7037

Merged
ggainey merged 1 commit intopulp:mainfrom
balasankarc:add-max-concurrent-content
Oct 22, 2025
Merged

Allow batch size of artifacts processed during sync to be configured#7037
ggainey merged 1 commit intopulp:mainfrom
balasankarc:add-max-concurrent-content

Conversation

@balasankarc
Copy link
Copy Markdown

closes #7024

Instead of hardcoding a value of 200, which can cause the storage requirements to increase drastically, allow batch size of artifacts processed during sync to be configured by users.

@dkliban
Copy link
Copy Markdown
Member

dkliban commented Oct 21, 2025

@balasankarc Thank you for the contribution. The CI failures are not related to your changes. We will accept this change once we have our CI working.

In the future it would better if this setting was available on each remote. Setting it globally to a low number will cause significantly more load on the database.

@balasankarc
Copy link
Copy Markdown
Author

@balasankarc Thank you for the contribution. The CI failures are not related to your changes. We will accept this change once we have our CI working.

In the future it would better if this setting was available on each remote. Setting it globally to a low number will cause significantly more load on the database.

@dkliban I'll work on the setting being per-remote as a different PR, as next iteration. So this one can solve the immediate problem and unblock us, and the next one enhances it to be better from a performance PoV.

@dralley
Copy link
Copy Markdown
Contributor

dralley commented Oct 22, 2025

FYI, CI should be fixed once you rebase onto the latest state of the main branch

closes pulp#7024

Signed-off-by: Balasankar 'Balu' C <balu@dravidam.net>
@balasankarc balasankarc force-pushed the add-max-concurrent-content branch from 73d1217 to 73e1850 Compare October 22, 2025 03:27
@balasankarc
Copy link
Copy Markdown
Author

@dralley Done.

@ggainey ggainey merged commit 6ce3efc into pulp:main Oct 22, 2025
14 checks passed
@balasankarc
Copy link
Copy Markdown
Author

@ggainey Is there a regular minor version release coming out soon, that may include this fix? If not, would it be possible to have a patch version out with this fix?

@ggainey
Copy link
Copy Markdown
Contributor

ggainey commented Oct 22, 2025

@ggainey Is there a regular minor version release coming out soon, that may include this fix? If not, would it be possible to have a patch version out with this fix?

We generally do new Y-releases as needed, on Tuesdays. As it stands, I not sure we can backport this - what happens to existing installs that don't have the new setting, but install the new code? @dkliban wdyt?

@balasankarc
Copy link
Copy Markdown
Author

@ggainey Is there a regular minor version release coming out soon, that may include this fix? If not, would it be possible to have a patch version out with this fix?

We generally do new Y-releases as needed, on Tuesdays. As it stands, I not sure we can backport this - what happens to existing installs that don't have the new setting, but install the new code? @dkliban wdyt?

@ggainey That's fine. Is there a -Y release planned this week, which can include this?

/cc @bmbouter

@balasankarc balasankarc deleted the add-max-concurrent-content branch October 27, 2025 11:14
@ggainey
Copy link
Copy Markdown
Contributor

ggainey commented Oct 27, 2025

Yessir, "having a .feature available" is what triggers a new-Y on Tuesdays :)

@balasankarc
Copy link
Copy Markdown
Author

Awesome. TIL. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Allow batch size of artifacts processed during sync to be configured

4 participants