-
Notifications
You must be signed in to change notification settings - Fork 137
Add network configuration support for synchronous file uploads #7221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
pedro-psb
merged 1 commit into
pulp:main
from
vycius:7201-support-timeout-customization-for-sync-file-upload
Feb 3, 2026
Merged
Add network configuration support for synchronous file uploads #7221
pedro-psb
merged 1 commit into
pulp:main
from
vycius:7201-support-timeout-customization-for-sync-file-upload
Feb 3, 2026
+257
−241
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
50e31fd to
26f39f5
Compare
pedro-psb
requested changes
Jan 22, 2026
26f39f5 to
5719167
Compare
218e42f to
a5e6bfd
Compare
Contributor
Author
|
@pedro-psb Thanks for the feedback. Pull request is ready for review. |
a5e6bfd to
eced14f
Compare
pedro-psb
requested changes
Jan 29, 2026
eced14f to
8ce9727
Compare
35ed195 to
ddf4ad7
Compare
ddf4ad7 to
3548a73
Compare
Introduce RemoteNetworkConfigSerializer to centralize shared network settings (timeouts, proxies, and certificates) and ensure consistent validation across persistent Remotes and ad-hoc upload downloads. - Exclude sync-specific fields (policy, rate_limit) from shared config - Pass validated network kwargs to the downloader in UploadSerializerFieldsMixin - Reuse common proxy and certificate validation logic closes: pulp#7201
3548a73 to
2e43dc4
Compare
pedro-psb
approved these changes
Feb 3, 2026
Member
pedro-psb
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks! Looks good.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce RemoteNetworkConfigSerializer to centralize shared network settings (timeouts, proxies, and certificates) and ensure consistent validation across persistent Remotes and ad-hoc upload downloads.
closes: #7201