Fix GroupRoleSerializer domain field view_name typo#7347
Open
Fix GroupRoleSerializer domain field view_name typo#7347
Conversation
closes pulp#7095 Assisted-by: Claude (claude-4.6-opus) Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
Author
|
This PR is a test of the new claude.md changes here: #7345. Prompts used: The first prompt solved the problem. The second one wrote a unit test and checked that it passed. The next three were me reviewing the fix and why it worked and getting it to use a functional test. The last one created the changelog entry and commit, then push and created the PR. Seems we need a lint step in the PR checklist, although that should soon be replaced with the pre-commit lint hook. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
GroupRoleSerializer.domainfield:view_name="domain-detail"→view_name="domains-detail", matching the correct URL pattern name used inUserRoleSerializer.NoReverseMatcherror (HTTP 500) whenever a group role with a non-null domain was serialized, and also when rendering the browsable API form (which enumerates domain choices).Test plan
test_group_roles_with_domainthat creates a group role with the default domain and verifies it can be listed and the domain href is correct.Fixes #7095
Made with Cursor