Skip to content

Expose StableOrderingFilter in pulpcore.plugin API#7737

Merged
ggainey merged 1 commit into
pulp:mainfrom
jerabekjiri:expose-stable-ordering-filter
May 20, 2026
Merged

Expose StableOrderingFilter in pulpcore.plugin API#7737
ggainey merged 1 commit into
pulp:mainfrom
jerabekjiri:expose-stable-ordering-filter

Conversation

@jerabekjiri
Copy link
Copy Markdown
Contributor

Expose StableOrderingFilter in pulpcore.plugin.viewsets so plugin repos can import it from the public API (from pulpcore.plugin import StableOrderingFilter) instead of reaching into the internal pulpcore.filters module directly.

Required for pulp/pulp_ansible#2555

📜 Checklist

  • Commits are cleanly separated with meaningful messages (simple features and bug fixes should be squashed to one commit)
  • A changelog entry or entries has been added for any significant changes
  • Follows the Pulp policy on AI Usage
  • (For new features) - User documentation and test coverage has been added

See: Pull Request Walkthrough

Add StableOrderingFilter to pulpcore.plugin.viewsets exports so
plugin repos can import it from the public API surface instead of
reaching into pulpcore.filters directly.

Assisted-By: Claude Opus 4.6 (Anthropic)
@ggainey ggainey merged commit 85a5428 into pulp:main May 20, 2026
13 of 14 checks passed
@patchback
Copy link
Copy Markdown

patchback Bot commented May 20, 2026

Backport to 3.49: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 85a5428 on top of patchback/backports/3.49/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737

Backporting merged PR #7737 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.49/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737 upstream/3.49
  4. Now, cherry-pick PR Expose StableOrderingFilter in pulpcore.plugin API #7737 contents into that branch:
    $ git cherry-pick -x 85a5428497064b776f056dc34ec9e2257370d20a
    If it'll yell at you with something like fatal: Commit 85a5428497064b776f056dc34ec9e2257370d20a is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 85a5428497064b776f056dc34ec9e2257370d20a
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Expose StableOrderingFilter in pulpcore.plugin API #7737 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.49/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 20, 2026

Backport to 3.63: 💔 cherry-picking failed — conflicts found

❌ Failed to cleanly apply 85a5428 on top of patchback/backports/3.63/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737

Backporting merged PR #7737 into main

  1. Ensure you have a local repo clone of your fork. Unless you cloned it
    from the upstream, this would be your origin remote.
  2. Make sure you have an upstream repo added as a remote too. In these
    instructions you'll refer to it by the name upstream. If you don't
    have it, here's how you can add it:
    $ git remote add upstream https://github.com/pulp/pulpcore.git
  3. Ensure you have the latest copy of upstream and prepare a branch
    that will hold the backported code:
    $ git fetch upstream
    $ git checkout -b patchback/backports/3.63/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737 upstream/3.63
  4. Now, cherry-pick PR Expose StableOrderingFilter in pulpcore.plugin API #7737 contents into that branch:
    $ git cherry-pick -x 85a5428497064b776f056dc34ec9e2257370d20a
    If it'll yell at you with something like fatal: Commit 85a5428497064b776f056dc34ec9e2257370d20a is a merge but no -m option was given., add -m 1 as follows instead:
    $ git cherry-pick -m1 -x 85a5428497064b776f056dc34ec9e2257370d20a
  5. At this point, you'll probably encounter some merge conflicts. You must
    resolve them in to preserve the patch from PR Expose StableOrderingFilter in pulpcore.plugin API #7737 as close to the
    original as possible.
  6. Push this branch to your fork on GitHub:
    $ git push origin patchback/backports/3.63/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737
  7. Create a PR, ensure that the CI is green. If it's not — update it so that
    the tests and any other checks pass. This is it!
    Now relax and wait for the maintainers to process your pull request
    when they have some cycles to do reviews. Don't worry — they'll tell you if
    any improvements are necessary when the time comes!

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 20, 2026

Backport to 3.73: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.73/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737

Backported as #7740

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 20, 2026

Backport to 3.85: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.85/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737

Backported as #7741

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 20, 2026

Backport to 3.105: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.105/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737

Backported as #7742

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

@patchback
Copy link
Copy Markdown

patchback Bot commented May 20, 2026

Backport to 3.112: 💚 backport PR created

✅ Backport PR branch: patchback/backports/3.112/85a5428497064b776f056dc34ec9e2257370d20a/pr-7737

Backported as #7743

🤖 @patchback
I'm built with octomachinery and
my source is open — https://github.com/sanitizers/patchback-github-app.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants