Cirrus: Update brew uninstall node@20 to brew uninstall node@24#1465
Merged
Cirrus: Update brew uninstall node@20 to brew uninstall node@24#1465
brew uninstall node@20 to brew uninstall node@24#1465Conversation
This used to come preinstalled in Cirrus's base CI image, and caused us some problems before, so we uninstalled it. Now, with this Node package version being deprecated in Homebrew, it is no-longer preinstalled in Cirrus' base CI image, so we don't have to uninstall it manually! Also, trying to uninstall this when it wasn't already installed was causing an error: ``` brew uninstall node@20 Error: No such keg: /opt/homebrew/Cellar/node@20 ``` (Avoid CI-run-breaking errors with this one weird trick!)
Cirrus' base CI image comes with node@24 now, not node@20 like it did before. We install Node 16 using tj/n, so we can get rid of this copy from Homebrew.
DeeDeeG
changed the title
brew uninstall node@20 to brew uninstall node@24
confused-Techie
approved these changes
Feb 25, 2026
Member
confused-Techie
left a comment
confused-Techie
left a comment
There was a problem hiding this comment.
Can confirm that now the linked cirrus run is successfully installing the correct node version and not erroring out.
LGTM! Thanks for noticing & fixing this!
Member
Author
|
We could also switch to actually setting up Node 20 instead of 16 in Cirrus, if that's what we're moving to everywhere. It's nice to know contributors can still get the repo working with Node 16 on their system for now, though. (It should not matter since we rebuild all the native code for Electron anyhow during the build process.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cirrus replaced deprecated Homebrew
node@20package with non-deprecated Homebrewnode@24in their base CI images. So, bump thebrew uninstall node@20line tobrew uninstall node@24instead. (This Homebrew copy of Node has caused us some issues before, so we have been removing it. We install Node 16 using https://github.com/tj/n, so we can get rid of this copy of Node from Homebrew.)Note: trying to uninstall
node@20when it wasn't already installed was causing an error:(Avoid CI-run-breaking errors with this one weird trick!)
Verification process
Gets all the way through preparation and building, passes visual tests... https://cirrus-ci.com/task/4843477726396416?logs=test#L69 Looking good! ✅
(Note: This was a macOS-only issue, so I canceled the Linux task to save credits. It was a Cirrus-only issue as well, so I cancelled all GitHub Actions CI workflows as well.)