Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@PressJump
Copy link
Member

@PressJump PressJump commented Nov 8, 2022

Upgrade Firefox to 106.0.5, fixing bad patches and removing Firefox-view button on the top left.

Fixes #113

@PressJump PressJump requested a review from trickypr November 8, 2022 14:26
@PressJump PressJump added the upgrade Updating firefox or a dependancy to a more recent version. label Nov 8, 2022
Copy link
Contributor

@splatboydev splatboydev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think trigure might be a misspelling but it looks fine other than that.

+  /**
+   * Displays the welcome dialog. Trigured `_maybeShowDefaultBrowserPrompt`.
+   *
+   * @todo Add gluon docs for how to show custom popups on startup
+   * @patch Pulse Browser
+   */

@trickypr
Copy link
Member

Will review this on Friday afternoon or Saturday

@PressJump
Copy link
Member Author

PressJump commented Nov 11, 2022

QA Requirements

  • Sidebar

    • The sidebar exists
    • The settings and addons button are visible down the bottom
    • The bookmarks, history and synced tabs icons are in the sidebar
    • The sidebar can be resized properly
    • An installed extension will appear in the sidebar
    • Sidebar-Tabs is Loaded and has a button visible down the bottom
    • Sidebar-Tabs can add a sidebar item to the sidebar
    • Sidebar-Tabs can remove a sidebar item to the sidebar
  • Extensions

    • Tabliss is loading correctly
    • Tabliss does not have the webextention symbol in the title bar
    • uBlock origin is loading correctly
    • QR-Generator is loading correctly
  • About dialog

    • The new about dialog is present
    • The dialog has not significantly changed
  • Pocket

    • Pocket is not present in the browser
  • Preferences

    • All tabs in preferences open
    • The "More from {Vendor}" option is not present
    • The sidebar preferences are present and work as expected
  • Welcome experience

    • The import button opens the import wizard
    • The theme picker is present and works as expected
    • The search engine picker is present and works as expected
  • Pulse theme

    • The tabs appear to be consistent
  • Mozilla theme

    • The sidebar tabs are correct
  • Useragent

    • The user agent is reporting as Mozilla Firefox

@PressJump
Copy link
Member Author

PressJump commented Nov 11, 2022

Search engine picker does not work as expected from the welcome experience but other QA checks pass.

Copy link
Member

@trickypr trickypr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to fix QA bugs before merging

@trickypr trickypr self-requested a review November 13, 2022 09:01
@PressJump PressJump merged commit 8661519 into beta Nov 13, 2022
@PressJump PressJump deleted the firefox-106.0.5 branch November 13, 2022 09:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

upgrade Updating firefox or a dependancy to a more recent version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants