Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@trickypr
Copy link
Member

No description provided.

@trickypr trickypr added the refinement Something that should use refinement label Jan 17, 2023
@trickypr trickypr requested a review from PressJump January 17, 2023 09:45
@PressJump
Copy link
Member

Checking this out at the moment but was met with this on start.
image
Not too sure if it was a build issue but rebuilding from clean to double check.

@PressJump
Copy link
Member

I am having the same results with a clean build unfortunately. @trickypr

@trickypr
Copy link
Member Author

@PressJump Rereview

@trickypr
Copy link
Member Author

trickypr commented Feb 1, 2023

@PressJump Ping

@PressJump
Copy link
Member

@PressJump Ping

I have been summoned. Was the issue I had referenced fixed?

@trickypr
Copy link
Member Author

trickypr commented Feb 1, 2023

It should be, can you re-review?

@PressJump
Copy link
Member

It should be, can you re-review?

Rebuilding at the moment.

Copy link
Member

@PressJump PressJump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe the font is too large but otherwise it looks good to me and the issue seems to be fixed.

@trickypr
Copy link
Member Author

trickypr commented Feb 1, 2023

The font size is intentional, it is a workaround for #148

@trickypr trickypr merged commit c886ba1 into alpha Feb 1, 2023
@trickypr trickypr deleted the better-welcome branch February 1, 2023 10:50
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

refinement Something that should use refinement

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More interesting setup Choose Tab Orientation on Setup Font in theme selector appears squished

4 participants