Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@trickypr
Copy link
Member

@trickypr trickypr commented Jan 18, 2023

Firefox Update

Fixes #156
Fixes #186

QA Requirements

  • Sidebar

    • The sidebar exists
    • The settings and addons button are visible down the bottom
    • The bookmarks, history and synced tabs icons are in the sidebar
    • The sidebar can be resized properly
    • An installed extension will appear in the sidebar
    • Sidebar-Tabs is Loaded and has a button visible down the bottom
    • Sidebar-Tabs can add a sidebar item to the sidebar - @PressJump I don't think I can update to 0.5.0 right?
    • Sidebar-Tabs can remove a sidebar item to the sidebar
    • The sidebar keeps tabs active while closed when keep sidebar tabs active is set to true
    • The sidebar overwrites tabs when keep sidebar tabs active is set to false
  • Extensions

    • Tabliss is loading correctly
    • Tabliss does not have the webextention symbol in the title bar
    • uBlock origin is loading correctly
    • QRCode generator is loading correctly
  • About dialog

    • The new about dialog is present
    • The dialog has not significantly changed
  • Pocket

    • Pocket is not present in the browser
  • Preferences

    • All tabs in preferences open
    • The "More from {Vendor}" option is not present
    • The sidebar preferences are present and work as expected
  • Welcome experience

    • The import button opens the import wizard
    • The theme picker is present and works as expected
    • The search engine picker is present and works as expected
  • Pulse theme

    • The tabs appear to be consistent
  • Mozilla theme

    • The sidebar tabs are correct
  • Useragent

    • The user agent is reporting as Mozilla Firefox

@trickypr trickypr added the upgrade Updating firefox or a dependancy to a more recent version. label Jan 18, 2023
@trickypr trickypr requested a review from PressJump January 18, 2023 09:14
@trickypr trickypr self-assigned this Jan 18, 2023
@PressJump
Copy link
Member

Yea no don't update to 0.5.0 as it bricks sidebar. Will be fixing it promptly after reviewing.

Copy link
Member

@PressJump PressJump left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🎉 109.0

@trickypr trickypr merged commit fe3d24e into alpha Jan 20, 2023
@trickypr trickypr deleted the 109.0 branch January 20, 2023 01:49
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

upgrade Updating firefox or a dependancy to a more recent version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

More Browser Imports ❗ Pulse has out of date dependencies

3 participants