Skip to content
This repository was archived by the owner on Sep 30, 2024. It is now read-only.

Conversation

@trickypr
Copy link
Member

Firefox Update

Reviewers check the following before continuing:

QA Requirements

  • Sidebar

    • The sidebar exists
    • The settings and addons button are visible down the bottom
    • The bookmarks, history and synced tabs icons are in the sidebar
    • The sidebar can be resized properly
    • An installed extension will appear in the sidebar
    • Sidebar-Tabs is Loaded and has a button visible down the bottom
    • Sidebar-Tabs can add a sidebar item to the sidebar
    • Sidebar-Tabs can remove a sidebar item to the sidebar
    • The sidebar keeps tabs active while closed when keep sidebar tabs active is set to true
    • The sidebar overwrites tabs when keep sidebar tabs active is set to false
  • Extensions

    • Tabliss is loading correctly
    • Tabliss does not have the webextention symbol in the title bar
    • uBlock origin is loading correctly
    • QRCode generator is loading correctly
  • About dialog

    • The new about dialog is present
    • The dialog has not significantly changed
  • Pocket

    • Pocket is not present in the browser
  • Preferences

    • All tabs in preferences open
    • The "More from {Vendor}" option is not present
    • The sidebar preferences are present and work as expected
  • Welcome experience

    • The import button opens the import wizard
    • The theme picker is present and works as expected
    • The search engine picker is present and works as expected
  • Pulse theme

    • The tabs appear to be consistent
  • Mozilla theme

    • The sidebar tabs are correct
  • Useragent

    • The user agent is reporting as Mozilla Firefox
  • Are all extensions up to date?

  • Has better-fox.js been updated to the relevant version? (Note, the version has not been merged into master, we need to do this again when v.110 yokoffing/Betterfox#150 merges)

    • Have user_prefs been changed to pref?

@trickypr trickypr added the upgrade Updating firefox or a dependancy to a more recent version. label Feb 18, 2023
@trickypr trickypr requested a review from PressJump February 18, 2023 08:46
@trickypr
Copy link
Member Author

trickypr commented Feb 18, 2023

Note: Windows CI has decided that network connections are for the weak, so it might take significantly longer to get this in an alpha build :(

@PressJump
Copy link
Member

I have been naturally pinged, will check it out soon ;)

@trickypr trickypr merged commit e9fd5fa into alpha Feb 19, 2023
@trickypr trickypr deleted the 110.0 branch February 19, 2023 02:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

upgrade Updating firefox or a dependancy to a more recent version.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants