fix: use composition DAG to determine callee_defines_resource#48
Merged
Conversation
A callee that also imports the same interface is a re-exporter, not the resource definer. Check resolved_imports to determine if the callee re-exports: if (callee_comp, interface_name) appears as an importer in the resolution graph, set callee_defines_resource = false. This correctly distinguishes defining components (only export) from re-exporting intermediates (import AND export the same interface) without relying on canonical function entries or type definitions which are unreliable after flatten_nested_components. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checks resolved_imports to identify re-exporting intermediates. No regressions. 73/73 pass. Foundation for remaining 4 resource fixtures.