feat: unified resource types + graph re-exporter detection#54
Merged
Conversation
1. P2 wrapper now uses resource_name alone as type key (not interface_name). Different interfaces referencing the same resource get ONE shared type. Eliminates "wrong type" errors for multi-interface resource chains. 2. ResourceGraph second pass uses composition DAG to detect re-exporters: components that import ANY resource interface are not definers, even if they have canonical ResourceRep entries from re-export wiring. 3. Cleanup pass removes false-positive definers from the cache. resource_floats and resource_with_lists progress from "wrong type" to "unreachable" — resource types now compatible, remaining issue is adapter value routing (rep vs handle). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Shared resource types across interfaces + DAG-based re-exporter cleanup. resource_floats/resource_with_lists progress to 'unreachable' (types fixed). 73/73 pass.