fix: use resource_definer for graph override instead of is_reexporter#64
Merged
fix: use resource_definer for graph override instead of is_reexporter#64
Conversation
Replace is_reexporter (broken for cross-name re-exports) with a check that the graph knows about this resource and says the callee is NOT the definer. Uses defines_resource combined with resource_definer().is_some() as a knowledge guard. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replace
is_reexporter(broken for cross-name re-exports like resource_floats) with!defines_resource && resource_definer.is_some()— if the graph knows about thisresource and says the callee is NOT the definer, force
callee_defines_resource=false.This is infrastructure for fixing resource_floats (the adapter wiring still needs work).
No regressions — xcrate and all existing tests pass.
Test plan
🤖 Generated with Claude Code