-
Notifications
You must be signed in to change notification settings - Fork 0
Document embeds Phase 1: finish Tasks 4-6 #91
Copy link
Copy link
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Context
Branch feat/document-embeds has Tasks 1-3 committed (3 commits). Tasks 4-6 remain.
Spec: docs/superpowers/specs/2026-03-29-document-embeds-design.md (on docs/specs-and-plans branch)
Plan: docs/superpowers/plans/2026-03-29-embed-phase1.md
Completed (on branch)
- Task 1:
EmbedRequestparser + error types (7 tests) — commit3f24ad5 - Task 2: Stats + coverage HTML renderers (4 tests) — commit
e69d0d3 - Task 3: Refactor
render_to_htmlwithembed_resolverclosure (2 tests) — commit71595c4- Note: needs build verification — syspolicyd was at 100% CPU preventing clean builds. Kill syspolicyd first:
sudo kill -9 $(pgrep syspolicyd)
- Note: needs build verification — syspolicyd was at 100% CPU preventing clean builds. Kill syspolicyd first:
Remaining
- Task 4:
rivet embedCLI command —Command::Embedvariant,cmd_embed()handler (3 tests) - Task 5: Export provenance stamps + dirty-tree warning — SC-EMBED-1, SC-EMBED-4 (3 tests)
- Task 6: E2E integration tests + Playwright regression (7 tests)
After Tasks 4-6
- Run full test suite (
cargo test && cargo clippy) - Squash commits and recommit in main checkout (worktree pre-commit hooks broken)
- Create PR
- Add Playwright E2E tests for embeds in documents
Key files
rivet-core/src/embed.rs— parser, resolver, renderersrivet-core/src/document.rs— refactoredrender_to_htmlwithembed_resolverclosurerivet-cli/src/render/documents.rs— passes embed resolver torender_to_htmlrivet-core/src/export.rs— placeholder resolver (Task 5 adds provenance)
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request