feat: sphinx-needs JSON import adapter (migration path)#143
Merged
Conversation
Add needs-json format support to the import-results CLI command, enabling sphinx-needs users to import their needs.json exports into rivet as generic YAML artifacts. The core adapter (rivet-core/src/formats/needs_json.rs) was already implemented with full support for type mapping, ID normalization (underscore to hyphen), configurable link types, tag/status preservation, and extra field forwarding. This commit wires it into the CLI's import-results command so users can run: rivet import-results --format needs-json needs.json --output artifacts/ Implements: REQ-025 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 1c38ff9 | Previous: 9db1988 | Ratio |
|---|---|---|---|
link_graph_build/10000 |
28806377 ns/iter (± 2857931) |
23949147 ns/iter (± 1257918) |
1.20 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Wires the existing needs-json import adapter into the CLI:
needs.jsonexport formatrivet validateThis provides the migration path for projects currently using sphinx-needs.
Implements: REQ-025
🤖 Generated with Claude Code