Skip to content

fix(windows): gate chmod behind cfg(unix) to unblock v0.4.0 release #153

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
Apr 20, 2026
+7 −4
Merged

fix(windows): gate chmod behind cfg(unix) to unblock v0.4.0 release #153

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions rivet-cli/src/main.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2504,8 +2504,6 @@ fn which_rivet() -> String {
///
/// This allows coexistence with pre-commit, husky, lefthook, etc.
fn install_hook(path: &std::path::Path, content: &str) -> Result<()> {
use std::os::unix::fs::PermissionsExt;

if path.exists() {
let prev = path.with_extension("prev");
// Don't overwrite an existing .prev (user may have modified it)
Expand All @@ -2530,8 +2528,13 @@ fn install_hook(path: &std::path::Path, content: &str) -> Result<()> {

let final_content = format!("{content}{chain_snippet}");
std::fs::write(path, &final_content).with_context(|| format!("writing {}", path.display()))?;
std::fs::set_permissions(path, std::fs::Permissions::from_mode(0o755))
.with_context(|| format!("setting permissions on {}", path.display()))?;

#[cfg(unix)]
{
use std::os::unix::fs::PermissionsExt;
std::fs::set_permissions(path, std::fs::Permissions::from_mode(0o755))
.with_context(|| format!("setting permissions on {}", path.display()))?;
}
Ok(())
}

Expand Down
Loading