fix(tests): health-check wait in serve_integration — unflakes Proptest#165
Closed
fix(tests): health-check wait in serve_integration — unflakes Proptest#165
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
3c0c08d to
60d728a
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The flake
`api_artifacts_unfiltered` and `api_artifacts_search` in `serve_integration.rs` intermittently fail on `assert_eq!(status, 200)` — parsed status is 0, meaning the HTTP response was empty or unparseable. Happens under Proptest (extended) load (PROPTEST_CASES=1000, high CPU pressure).
Root cause
`start_server()` waits for TCP accept, then returns. But the socket binds before the artifact store finishes loading. Under load, `fetch()` races and hits the server mid-load, getting a closed connection or an error response.
Fix
Poll `/api/v1/health` until it returns HTTP/1.1 200 before declaring the server ready. The health handler only becomes reachable after routing is fully initialized and the store is populated.
Same 30s timeout, same retry cadence — just a stricter readiness check.
Test plan
This PR blocks nothing it doesn't fix. Other PRs (#157 salsa especially) can rebase to pick this up.
🤖 Generated with Claude Code