fix(serve): variant banner link missing hx-push-url (v0.4.1 release hotfix)#182
Merged
fix(serve): variant banner link missing hx-push-url (v0.4.1 release hotfix)#182
Conversation
serve_lint::all_content_links_push_url caught a navigational <a> in the "Invalid variant scope" error banner that spanned two source lines: line 1 had hx-get + hx-target="#content", line 2 had hx-push-url. The per-line lint rightly flagged it. Collapse the attributes onto the same source line so the lint matches. Trace: skip
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: f0b9326 | Previous: a9169d3 | Ratio |
|---|---|---|---|
diff/10000 |
10443645 ns/iter (± 581410) |
7894503 ns/iter (± 424178) |
1.32 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
v0.4.1 release's test-evidence job failed on
serve_lint::all_content_links_push_url: the "Invalid variant scope" error banner link in views.rs:21 had itshx-push-urlattribute on the next source line fromhx-get+hx-target="#content", so the per-line lint flagged it.Collapsing onto one line. Test passes locally.
Once merged, I'll re-tag v0.4.1 on the fix commit.