Conversation
…wrap PR #215 (rendering-invariants.spec.ts) was authored before PR #217 (remaining Playwright fixes) and pinned the asymmetry: "description-mermaid is NOT wrapped in .svg-viewer (only diagram: field is)". PR #217 then closed that asymmetry — render/artifacts.rs now wraps description-mermaid in the same .svg-viewer container as the diagram: field. After both PRs landed on main, rendering-invariants.spec.ts:150 fails because main now wraps the mermaid that the test asserted is unwrapped. Flip the assertion to pin the new wrapped behavior (parity between description and diagram-field rendering). If a future change un-wraps, this assertion forces the change to be intentional. Trace: skip
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 9508fa7 | Previous: a3ce780 | Ratio |
|---|---|---|---|
traceability_matrix/1000 |
64626 ns/iter (± 302) |
44326 ns/iter (± 145) |
1.46 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR #215 pinned description-mermaid as unwrapped; PR #217 then wrapped it. Test now reflects current (wrapped) behavior. Resolves the only remaining Playwright failure on main.