test(serve): stabilise server_pages_push_url flake#318
Merged
Conversation
server_pages_push_url was using the default-5s `fetch` against /verification and /coverage — pages that iterate the dogfood corpus and sit on the timeout edge under CI runner load. Same flake class `fetch_with_timeout`'s own doc-comment already calls out for /graph. Observed flapping red on artifact-only PRs (#316) while passing on identical-surface #317 — runner-load dependent, not code. Replace with a small `fetch_page_with_retry` helper: 15s read timeout + one retry on `status == 0` (transient connection drop after the health probe has already passed). No assertion weakened; just absorbs the CI flake class. Verified locally: test passes in 2.42s.
📐 Rivet artifact deltaNo artifact changes in this PR. Code-only changes (renderer, CLI wiring, tests) don't touch the artifact graph. |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
`server_pages_push_url` (`rivet-cli/tests/serve_integration.rs:238`)
was flapping red on PRs that did not touch serve code (observed on
artifact-only #316 while passing on identical-surface #317). The test
uses the default-5s `fetch`, but iterates `/verification` and
`/coverage` — pages that walk the dogfood corpus and sit on the
timeout edge under CI runner load. Same flake class
`fetch_with_timeout`'s own doc-comment already calls out for `/graph`.
Fix: small `fetch_page_with_retry` helper — 15s read timeout + one
retry on `status == 0` (transient connection drop after the health
probe has already passed). No assertion weakened.
Verified locally: `cargo test -p rivet-cli --test serve_integration
server_pages_push_url` passes in 2.42s.
Test plan
(the real evidence is non-flakiness over time).
🤖 Generated with Claude Code