docs(artifacts): file REQ-091 (rowan-yaml link-loss) + REQ-092 (source-code linker)#323
Merged
Merged
Conversation
…e-code linker) REQ-091 — clean-room verification of a parallel agent's sphinx-needs bug report falsified the original attribution (`GenericYamlAdapter` / `parse_generic_yaml`) and pinpointed the actual offender: `yaml_hir::extract_schema_driven` — the default rowan-yaml salsa load path — silently returns 0 artifacts + 0 diagnostics for flush-left YAML, while `parse_generic_yaml` returns 1 artifact + 1 link from the same file. The link graph the default validator should grade is invisible. Contributing factor: `extract_links_via_serde` (the rowan parser's fallback) silently `Vec::new()`s on `serde_yaml::from_str` parse errors — F2 silent-failure ethos violation even at the fallback. Acceptance set covers both: same-output parity for both fixture shapes, default `rivet validate` reporting link errors for flush- left, parse-error diagnostic from the fallback, and re-grading the parallel agent's sphinx-needs corpus against the Python reference (~2500 warnings) once the fix lands. baseline: v0.13.1-track. REQ-092 — Eclipse S-CORE ships `score_source_code_linker` (per-line `// req-Id: <id>` traceability). Rivet has per-commit links via `rivet commits` trailers (REQ-051). Different granularity, both auditable. Files the new capability — `rivet source-link` — so projects converging from S-CORE → rivet have a clean migration path; baseline: v0.14.0-track. Refs: REQ-051, FEAT-135
📐 Rivet artifact delta
Graphgraph LR
REQ_091["REQ-091"]:::added
REQ_092["REQ-092"]:::added
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Added
Posted by |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: a11a585 | Previous: 75ce3fa | Ratio |
|---|---|---|---|
traceability_matrix/1000 |
60986 ns/iter (± 405) |
45376 ns/iter (± 365) |
1.34 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
REQ-091 — Clean-room verification of a parallel agent's sphinx-needs corpus bug report falsified the original attribution (`GenericYamlAdapter` / `parse_generic_yaml`) and pinpointed the real offender: `yaml_hir::extract_schema_driven` — the default `rowan-yaml` salsa load path — silently returns 0 artifacts + 0 diagnostics for flush-left YAML, while `parse_generic_yaml` returns 1 artifact + 1 link from the same file.
Probe matrix (against the bug fixture):
Contributing factor: `extract_links_via_serde` silently `Vec::new()`s on parse errors — F2 ethos violation in the fallback. baseline: `v0.13.1-track`.
REQ-092 — Eclipse S-CORE `score_source_code_linker` (per-line) vs rivet `commits` (per-commit, REQ-051). Files `rivet source-link` as a new capability for S-CORE → rivet migration. baseline: `v0.14.0-track`.
Test plan
🤖 Generated with Claude Code