fix(bazel): pin rules_wasm_component via git_override (Rocq Proofs unblocker)#328
Merged
Merged
Conversation
PR #315 added `bazel_dep(name = "rules_wasm_component", version = "1.0.0")` for the REQ-086 witness MC/DC work, but did not add a git_override clause. The Bazel Central Registry does not publish rules_wasm_component, so Bazel reports: ERROR: Error computing the main repository mapping: in module dependency chain <root> -> rules_wasm_component@1.0.0: module rules_wasm_component@1.0.0 not found in registries: * https://bcr.bazel.build/modules/rules_wasm_component/1.0.0/MODULE.bazel: not found …and the Rocq Proofs CI job exits non-zero after ~5 seconds. This has been red on every PR since #315 merged on 2026-05-23. Mirror the rules_rocq_rust pattern that already lives in this file: declare bazel_dep at the BCR version + git_override to the pulseengine repo at a pinned commit. Pin to fbe2057 (#470, "feat: add Nix flake for a reproducible development environment", 2026-05-22 — the most recent commit on rules_wasm_component default branch as of this fix and the closest to the date PR #315 was merged). Refs: REQ-086 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
First CI attempt on this branch surfaced a different Bazel error: ERROR: error during computation of main repo mapping: error running 'git reset --hard fbe20571eedaa75676b1f97e74dde0b3ff2f8050' while working with @rules_wasm_component+ The earlier fbe2057 commit is still in the upstream history but Bazel's shallow git fetch (and/or the self-hosted runner's git cache) can't resolve it on-demand. d2347fb is current main HEAD on rules_wasm_component — shallow clones land on it directly so the `git reset --hard` is a no-op. This isolates the unblocker to the production-side that actually works under our runner geometry. Refs: REQ-086 Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: bcc267c | Previous: 89f243c | Ratio |
|---|---|---|---|
store_insert/10000 |
17336324 ns/iter (± 2078544) |
12242554 ns/iter (± 359791) |
1.42 |
link_graph_build/10000 |
35635454 ns/iter (± 3605710) |
23196972 ns/iter (± 438410) |
1.54 |
validate/10000 |
19024398 ns/iter (± 2701047) |
12155462 ns/iter (± 114767) |
1.57 |
This comment was automatically generated by workflow using github-action-benchmark.
1 task
avrabe
added a commit
that referenced
this pull request
May 25, 2026
Same transient-connection-drop flake class that landed in fetch_page_with_retry (PR-train preceding v0.13.0). The raw TcpStream POST + read_to_end occasionally returns empty data on self-hosted-runner contention, leaving the HTTP status parsed as 0 and the assertion failing with "got status 0" — observed on PR #328 (no serve-code change in the PR, the failure was the test, not the production code). Extract a `post_reload_status` helper that retries once on `status == 0` after a 200 ms backoff (mirroring fetch_page_with_retry exactly), and use it from test_reload_yaml_error_returns_error_response. The other reload tests already work fine via fetch_with_timeout so they don't need the helper yet. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
May 25, 2026
Same transient-connection-drop flake class that landed in fetch_page_with_retry (PR-train preceding v0.13.0). The raw TcpStream POST + read_to_end occasionally returns empty data on self-hosted-runner contention, leaving the HTTP status parsed as 0 and the assertion failing with "got status 0" — observed on PR #328 (no serve-code change in the PR, the failure was the test, not the production code). Extract a `post_reload_status` helper that retries once on `status == 0` after a 200 ms backoff (mirroring fetch_page_with_retry exactly), and use it from test_reload_yaml_error_returns_error_response. The other reload tests already work fine via fetch_with_timeout so they don't need the helper yet. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
May 25, 2026
Same transient-connection-drop flake class that landed in fetch_page_with_retry (PR-train preceding v0.13.0). The raw TcpStream POST + read_to_end occasionally returns empty data on self-hosted-runner contention, leaving the HTTP status parsed as 0 and the assertion failing with "got status 0" — observed on PR #328 (no serve-code change in the PR, the failure was the test, not the production code). Extract a `post_reload_status` helper that retries once on `status == 0` after a 200 ms backoff (mirroring fetch_page_with_retry exactly), and use it from test_reload_yaml_error_returns_error_response. The other reload tests already work fine via fetch_with_timeout so they don't need the helper yet. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
May 25, 2026
Same transient-connection-drop flake class that landed in fetch_page_with_retry (PR-train preceding v0.13.0). The raw TcpStream POST + read_to_end occasionally returns empty data on self-hosted-runner contention, leaving the HTTP status parsed as 0 and the assertion failing with "got status 0" — observed on PR #328 (no serve-code change in the PR, the failure was the test, not the production code). Extract a `post_reload_status` helper that retries once on `status == 0` after a 200 ms backoff (mirroring fetch_page_with_retry exactly), and use it from test_reload_yaml_error_returns_error_response. The other reload tests already work fine via fetch_with_timeout so they don't need the helper yet. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
May 25, 2026
Same transient-connection-drop flake class that landed in fetch_page_with_retry (PR-train preceding v0.13.0). The raw TcpStream POST + read_to_end occasionally returns empty data on self-hosted-runner contention, leaving the HTTP status parsed as 0 and the assertion failing with "got status 0" — observed on PR #328 (no serve-code change in the PR, the failure was the test, not the production code). Extract a `post_reload_status` helper that retries once on `status == 0` after a 200 ms backoff (mirroring fetch_page_with_retry exactly), and use it from test_reload_yaml_error_returns_error_response. The other reload tests already work fine via fetch_with_timeout so they don't need the helper yet. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Unblocks Rocq Proofs CI on every PR (red since PR feat(compose-witness): Wasm-component PoC for REQ-086 witness MC/DC #315 merged).
The Bazel Central Registry doesn't publish `rules_wasm_component`,
so the bare `bazel_dep(name = "rules_wasm_component", version =
"1.0.0")` added in PR feat(compose-witness): Wasm-component PoC for REQ-086 witness MC/DC #315 fails module resolution after ~5s:
```
ERROR: Error computing the main repository mapping: in module
dependency chain -> rules_wasm_component@1.0.0: module
rules_wasm_component@1.0.0 not found in registries:
```
Mirror the `rules_rocq_rust` pattern that already lives in
MODULE.bazel: keep the BCR-version `bazel_dep`, add a
`git_override` to `pulseengine/rules_wasm_component` pinned to a
specific commit.
Pin rationale
development environment" (#470), 2026-05-22.
merged (2026-05-23). Conservative pin.
Test plan
Refs: REQ-086
🤖 Generated with Claude Code