ci(release-npm): preflight npm-auth check (loud-fail on bad/expired token)#342
Merged
Conversation
…oken) The npm channel silently froze at 0.10.1 for ~6 releases because NPM_TOKEN expired, then was replaced with a classic *Publish* token that fails under the org's 2FA-on-publish with EOTP — and the only signal was a per-package `npm publish` E404/EOTP crash deep in the job. Add a `npm whoami` preflight right after setup-node in both publish jobs. A bad/expired/wrong-type token now fails immediately with a labeled ::error:: telling the maintainer exactly what to do (Automation or granular read-write token), instead of a cryptic per-platform publish failure. F2 loud-fail-over-silent-success ethos — the same principle rivet's own validators enforce. Refs: REQ-068
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 067b00e | Previous: 02784db | Ratio |
|---|---|---|---|
traceability_matrix/1000 |
60591 ns/iter (± 237) |
43650 ns/iter (± 2392) |
1.39 |
query/1000 |
8662 ns/iter (± 308) |
6620 ns/iter (± 193) |
1.31 |
query/10000 |
123674 ns/iter (± 2093) |
98130 ns/iter (± 941) |
1.26 |
document_parse/100 |
176091 ns/iter (± 1156) |
145284 ns/iter (± 642) |
1.21 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The npm channel silently froze at 0.10.1 for ~6 releases:
NPM_TOKENexpired, then was replaced with a classic Publish token that fails under the org's 2FA-on-publish withEOTP— and the only signal was a per-packagenpm publishE404/EOTP crash deep in the job.Adds a
npm whoamipreflight right aftersetup-nodein both publish jobs. A bad/expired/wrong-type token now fails immediately with a labeled::error::telling the maintainer exactly what to do (mint an Automation or granular read-write token), instead of a cryptic per-platform publish failure.Same F2 "loud-fail over silent-success" principle rivet's own validators enforce.
Test plan
workflow_run/tag; this PR's CI just lints).Refs: REQ-068
🤖 Generated with Claude Code