fix(export): drop the localhost oEmbed discovery tag from static export (REQ-117)#368
Merged
Merged
Conversation
…rt (REQ-117) Bug-hunt finding (path-url-leakage, 3/3 lens-confirmed). Every exported artifact page emitted an oEmbed discovery `<link>` pointing at `http://localhost:<port>` — meaningful for the live serve dashboard, but broken metadata in `export --format html`, which is static and has no server (its RepoContext.port is 0). The tag is now emitted only when served (non-zero port). Verified on a real export: 0 oEmbed `<link>` tags, 0 `localhost:0`. Playwright guard added. Filed as REQ-117 (implemented). Implements: REQ-117 Verifies: REQ-117 Refs: REQ-105 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📐 Rivet artifact delta
Graphgraph LR
REQ_117["REQ-117"]:::modified
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Modified
Posted by |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 60fed60 | Previous: 68bc025 | Ratio |
|---|---|---|---|
store_lookup/100 |
2112 ns/iter (± 11) |
1660 ns/iter (± 3) |
1.27 |
store_lookup/1000 |
25344 ns/iter (± 406) |
19535 ns/iter (± 508) |
1.30 |
traceability_matrix/1000 |
64364 ns/iter (± 439) |
41047 ns/iter (± 92) |
1.57 |
query/1000 |
7375 ns/iter (± 74) |
5292 ns/iter (± 27) |
1.39 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug-hunt finding (REQ-117, 3/3 lens-confirmed). Static
export --format htmlemitted an oEmbed discovery<link>pointing athttp://localhost:<port>on every page — broken metadata with no server (export'sRepoContext.portis 0). Now emitted only when served. Verified on a real export (0 oEmbed tags, 0localhost:0); Playwright guard added.🤖 Generated with Claude Code