fix(reqif): import fails on a title-less SPEC-OBJECT (REQ-123, F2)#376
Merged
Conversation
Bug-hunt finding (f2-silent-failure, 3/3 lens-confirmed). A SPEC-OBJECT with no `ReqIF.Name` attribute and no `@LONG-NAME` imported as an artifact with an empty `title` (a required base field) via `.unwrap_or_default()` — a silently-invalid artifact that masked the missing required field. Import now returns an Err naming the object when the title would be empty, surfacing the missing field at import instead of producing a degraded artifact. Completes the ReqIF F2 silent-failure sweep (REQ-119 enum drop, REQ-120 directory swallow, REQ-123 empty title). Regression test `parse_reqif_fails_on_titleless_spec_object`; all 46 reqif tests green. Implements: REQ-123 Verifies: REQ-123 Refs: REQ-004 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
📐 Rivet artifact delta
Graphgraph LR
REQ_123["REQ-123"]:::modified
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Modified
Posted by |
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug-hunt finding (REQ-123, f2-silent-failure). A SPEC-OBJECT with no
ReqIF.Nameand no@LONG-NAMEimported as an artifact with an empty requiredtitleviaunwrap_or_default(). Import nowErrs naming the object. Completes the ReqIF F2 sweep (REQ-119 + REQ-120 + REQ-123). Regression test; all 46 reqif tests green; clippy --all-targets clean. Marks REQ-123 implemented.