fix(externals): resolve refs with a hyphenated (kebab) prefix (REQ-143)

[avrabe]

User report (0.14.0)

/artifacts/linc-mesh:A-AVTP-STREAM → Not Found. Artifact linc-mesh:A-AVTP-STREAM does not exist. …even though i browsed it and i know it is there. …generally still the external artifacts are not to be found.

Root cause

externals::parse_artifact_ref required the prefix to be purely is_ascii_lowercase() — no hyphens (the old doc-comment even said so). A kebab-case project slug like linc-mesh failed that check, so linc-mesh:A-AVTP-STREAM fell through to ArtifactRef::Local(...) and was looked up as a local id → 404.

The kicker: externals are stored as <prefix>:<id> using that same hyphenated prefix (ProjectContext does artifact.id = format!("{}:{}", ext.prefix, artifact.id)), so the parser no longer round-tripped its own output. Every external whose prefix contained a hyphen was unreachable in:

• the serve detail view (render_artifact_detail → parse_artifact_ref), and
• document link resolution (same function).

One shared gate, so one fix restores both surfaces.

Fix

Accept a kebab-case slug prefix: leading lowercase letter, then lowercase letters / digits / hyphens. Requiring a leading letter keeps an ordinary local id with a colon (e.g. H-1:2) from being misread as a cross-repo ref.

Verification

• New tests: linc-mesh:A-AVTP-STREAM and linc2:REQ-1 → External; H-1:2 and -bad:REQ-1 → Local. The existing H-1.2 and rivet:REQ-001 cases still pass. All 28 externals::tests green.
• Kani round-trip proof updated to the new prefix contract.
• clippy --all-targets + fmt clean; rivet validate PASS.

Also in this iteration (triaged, filed, not yet fixed)

Two more user reports filed as draft REQs to work next:

• REQ-144 — source-view links match substrings (SWR-001 wrongly linked inside SDV-BCM-SWR-001); render/source.rs uses str::contains, needs whole-token match.
• REQ-145 — JUnit import should honor a per-testcase rivet_tc_id property instead of classname.name.

Fixes: REQ-143

🤖 Generated with Claude Code

[github-actions]

📐 Rivet artifact delta

Change	Count
Added	3
Removed	0
Modified	0
Downstream impacted (depth ≤ 5)	0

Graph

graph LR
  REQ_143["REQ-143"]:::added
  REQ_144["REQ-144"]:::added
  REQ_145["REQ-145"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3

Loading

Added

• REQ-143
• REQ-144
• REQ-145

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-384 — download from the workflow run.

_{Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.}

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!