test: Playwright E2E suite + etch port rendering#39
Closed
Conversation
8 spec files covering: - routes.spec.ts: smoke test 21 dashboard routes (HTTP 200, valid HTML) - navigation.spec.ts: direct URL, back/forward, reload button - artifacts.spec.ts: filter/sort/pagination via URL params - stpa.spec.ts: hierarchy, H-13 presence, filter bar, fold/unfold - graph.spec.ts: SVG rendering, focus, node budget - print-mode.spec.ts: ?print=1 strips nav/HTMX - url-state.spec.ts: filter/sort/page state survives reload - validation.spec.ts: severity filter, text search CI integration: Playwright job in ci.yml with Chromium, artifact upload. Verifies: FEAT-052 Refs: REQ-007, SC-15 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Major etch rendering upgrade with three capabilities: Port-aware layout (RENDER-REQ-002): - PortInfo, PortSide, PortDirection, PortType data model - position_ports() with side-aware placement and auto-resolution - Node height grows for port count, edge-to-port snapping - SVG rendering: circles, direction triangles, type colors Orthogonal edge routing (RENDER-REQ-001): - ortho.rs: visibility-graph A* router with obstacle avoidance - EdgeRouting::Orthogonal (default) vs CubicBezier (legacy) - SVG polyline L commands for axis-aligned segments Interactive HTML wrapper (RENDER-REQ-003, 005, 006): - html.rs + embedded JS: pan, zoom, selection, group highlight - Semantic zoom CSS classes, URL ?highlight= deep linking - Zero external dependencies Backward compatible: ports/source_port/target_port default to empty/None. Trace: skip Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 970c7ed | Previous: 73f4055 | Ratio |
|---|---|---|---|
validate/100 |
44199 ns/iter (± 348) |
35796 ns/iter (± 188) |
1.23 |
validate/10000 |
7205631 ns/iter (± 763990) |
5446388 ns/iter (± 407815) |
1.32 |
This comment was automatically generated by workflow using github-action-benchmark.
Contributor
Author
|
Playwright tests and etch rendering already merged to main. Dashboard work in #40. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code