Skip to content

feat(scripts): Zola export build smoke check (REQ-138, #378)#391

Merged
avrabe merged 1 commit into
mainfrom
feat/zola-export-smoke-check
Jun 2, 2026
Merged

feat(scripts): Zola export build smoke check (REQ-138, #378)#391
avrabe merged 1 commit into
mainfrom
feat/zola-export-smoke-check

Conversation

@avrabe
Copy link
Copy Markdown
Contributor

@avrabe avrabe commented Jun 2, 2026

Closes #378 (the script half of REQ-138).

What

scripts/zola-export-smoke.sh is the end-to-end check the string-asserting unit tests can't give: it scaffolds a Zola site whose base_url is a sub-directory deploy (GitHub-Pages project-site style), runs rivet export --format zola --shortcodes into it, runs a real zola build, and fails if:

  1. zola build errors (broken shortcode, dangling @/ internal link, missing taxonomy, …), or
  2. any built-HTML href/src is an absolute /<prefix>/artifacts/… or /<prefix>/documents/… path that drops the deploy sub-path (the REQ-115/116/118 class).

"export succeeded" now provably implies "the site builds and its links resolve under a sub-directory." Skips cleanly (exit 0 + notice) when zola isn't installed, so it can gate on availability.

Verification (local, zola 0.22.1)

Follow-up

Wiring this as a gated CI job needs a zola install step on the self-hosted runners (no existing zola-in-CI pattern to reuse); I deliberately didn't commit an unverifiable workflow change. The script is runnable in CI today via RIVET_BIN=… scripts/zola-export-smoke.sh once zola is on PATH.

Implements: REQ-138

🤖 Generated with Claude Code

Adds scripts/zola-export-smoke.sh: exports the corpus into a scaffolded
Zola site whose base_url is a sub-directory deploy, runs a real
`zola build`, and fails on a build error OR on any built-HTML
artifact/document link that drops the deploy sub-path.

This is the end-to-end gate the string-asserting unit tests can't give —
"export succeeded" now provably implies "the site builds and its links
resolve under a sub-directory deploy." It catches the REQ-115/116/118
absolute-link class that previously shipped undetected. The script skips
cleanly (exit 0 + notice) when `zola` is absent, so it can gate on
availability.

Verified locally: passes on the current corpus (1219 pages, 0 leaks);
the leak detector fires on the pre-fix `/<prefix>/artifacts/…` pattern
while ignoring correctly-resolved full-URL links. Wiring it as a gated
CI job (needs a zola install on the runner) is a follow-up.

Implements: REQ-138
Refs: REQ-115

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Jun 2, 2026

📐 Rivet artifact delta

Change Count
Added 0
Removed 0
Modified 1
Downstream impacted (depth ≤ 5) 0

Graph

graph LR
  REQ_138["REQ-138"]:::modified
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Loading
Modified
ID Changes
REQ-138

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-391download from the workflow run.

Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.

Copy link
Copy Markdown

@github-actions github-actions Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite Current: 08e4228 Previous: 02b6893 Ratio
traceability_matrix/1000 60112 ns/iter (± 580) 44805 ns/iter (± 286) 1.34

This comment was automatically generated by workflow using github-action-benchmark.

@avrabe avrabe merged commit a37bda6 into main Jun 2, 2026
19 of 38 checks passed
@avrabe avrabe deleted the feat/zola-export-smoke-check branch June 2, 2026 08:33
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 2, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Zola export has no end-to-end 'does it actually build?' check — subdir-deploy breakage ships silently

1 participant