chore(artifacts): dogfood REQ audit — flip REQ-134, reconcile REQ-149 duplicate, file REQ-150

[avrabe]

A hands-on dogfooding pass: used rivet list --type requirement + rivet validate --explain to audit the REQs filed over recent iterations and reconcile their statuses. Each finding verified against merged code.

Marked implemented

• REQ-134 (per-project field extension for built-in types) → implemented. Both acceptance criteria are met: the schema-merge field-union mechanism works (verified empirically last iteration) and it's documented in docs/schemas.md (docs(schemas): recipe for extending a built-in artifact type with project fields (REQ-149, #350) #395).

Duplicate reconciled

• REQ-149 (the docs recipe I filed last iteration) was an accidental duplicate of the pre-existing REQ-134. Linked REQ-149 → REQ-134 (traces-to) + tagged it so it reads as the docs delivery of REQ-134, not a stray parallel requirement.

Left correctly draft (verified not fully met)

• REQ-128 — --orphans filter shipped (feat(list): --orphans — list artifacts disconnected from the graph (REQ-128) #373), but the inbound-link-count ranking report half is still outstanding.
• REQ-132 — REQ-147 did the single-hop link naming; the multi-hop chain naming this asks for is not done.
• REQ-135 — the validate/modify status-enum enforcement is built (feat(validate): retain base-fields + enforce status enum when declared (REQ-135) #370/feat(modify,add): reject a status outside the declared enum (REQ-135, #354) #371) but inert until the maintainer declares allowed-values + reconciles artifacts (policy, status lifecycle: enum has no values + promotion gates hardcode approved (advancing to implemented mis-fires; validate vs gaps-json disagree) #355).

New friction found + filed

• REQ-150 (draft): rivet add only rejects a duplicate id, not a duplicate intent — which is how I filed REQ-149 over REQ-134 without noticing. For the agent-driven workflow (agents filing findings as artifacts) this silently accretes near-duplicates. Proposed a non-blocking "similar to <ID>" advisory. Also filed as a GitHub issue.

rivet validate PASS.

Implements: REQ-134

🤖 Generated with Claude Code

[github-actions]

📐 Rivet artifact delta

Change	Count
Added	1
Removed	0
Modified	2
Downstream impacted (depth ≤ 5)	0

Graph

graph LR
  REQ_134["REQ-134"]:::modified
  REQ_149["REQ-149"]:::modified
  REQ_150["REQ-150"]:::added
  classDef added fill:#d4edda,stroke:#28a745,color:#155724
  classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
  classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
  classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3

Loading

Added

• REQ-150

Modified

ID	Changes
REQ-134
REQ-149

📎 Full HTML dashboard attached as workflow artifact rivet-delta-pr-396 — download from the workflow run.

_{Posted by rivet-delta workflow. The graph shows only changed artifacts; open the HTML dashboard (above) for full context.}

[github-actions]

⚠️ Performance Alert ⚠️

Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.

Benchmark suite	Current: 5d55c0b	Previous: 737a99c	Ratio
validate/10000	17993901 ns/iter (± 3830095)	14273310 ns/iter (± 228383)	1.26

This comment was automatically generated by workflow using github-action-benchmark.

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.

📢 Thoughts on this report? Let us know!