fix: cross-repo sync — git -c compatibility + detailed error messages#41
Merged
fix: cross-repo sync — git -c compatibility + detailed error messages#41
Conversation
…sages 1. Change git --config to git -c for hook protection. The --config long flag requires git 2.32+, but -c works on all git versions. This fixes CI failures on runners with older git. 2. Better error messages when external artifacts aren't found: - "external project has no rivet.yaml" with full path - "source does not exist at path" with expected location - "loaded 0 artifacts" warning with troubleshooting hint - Info log with artifact count on successful load Fixes: FEAT-034 Refs: SC-19 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 5ce5085 | Previous: ac932f0 | Ratio |
|---|---|---|---|
link_graph_build/10000 |
41905135 ns/iter (± 3429220) |
32017580 ns/iter (± 1801944) |
1.31 |
validate/10000 |
6304522 ns/iter (± 753907) |
5118452 ns/iter (± 378084) |
1.23 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two fixes for cross-repo linking:
git -c instead of --config — the
--configlong flag requires git 2.32+ but CI runners often have older git. Changed to-cwhich works on all versions.Detailed error messages — when external artifact loading fails, pinpoint exactly why:
Test plan
git_clone_disables_hookstest still passes (checkscore.hooksPath=/dev/nullstring)🤖 Generated with Claude Code