fix(serve): replace all href="#" with actual paths#46
Merged
Conversation
…n bug Every <a> tag with hx-get now has a matching href so that: - Right-click → Open in new tab works - Browser fallback without JavaScript works - No more /# URL on click 65 occurrences fixed across views.rs and components.rs. Positional format args converted to named args where needed to avoid index shifts. Fixes: FEAT-001 Refs: SSC-4 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 181a7ab | Previous: 0a62be5 | Ratio |
|---|---|---|---|
store_insert/10000 |
56272450 ns/iter (± 1897423) |
37737085 ns/iter (± 1054399) |
1.49 |
store_lookup/100 |
2190 ns/iter (± 10) |
1695 ns/iter (± 18) |
1.29 |
store_lookup/1000 |
26049 ns/iter (± 54) |
19452 ns/iter (± 313) |
1.34 |
traceability_matrix/1000 |
58910 ns/iter (± 359) |
40264 ns/iter (± 83) |
1.46 |
query/100 |
776 ns/iter (± 2) |
598 ns/iter (± 2) |
1.30 |
query/1000 |
7128 ns/iter (± 27) |
5051 ns/iter (± 10) |
1.41 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
<a>tag withhx-getnow has a matchinghrefso browser fallback worksviews.rsandcomponents.rs{}format args converted to named args where needed/#navigation bug when clicking links in the dashboardTest plan
cargo test --all— all tests passcargo +stable clippy -- -D warnings— cleangrep 'href="#"'on both files returns 0 matches🤖 Generated with Claude Code