fix(serve): exclude /assets/ from layout middleware, allow data: fonts in CSP#47
Merged
fix(serve): exclude /assets/ from layout middleware, allow data: fonts in CSP#47
Conversation
…s in CSP Two bugs: 1. The redirect middleware was wrapping /assets/htmx.js and /assets/mermaid.js responses in the HTML page shell, causing "Unexpected token '<'" errors in the browser. Fixed by excluding /assets/* paths from the middleware (same as /api/*, /wasm/*, etc.) 2. CSP header blocked base64-embedded fonts (data: URIs) because font-src defaulted to 'self'. Added explicit font-src 'self' data: directive. Fixes: FEAT-001 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/assets/htmx.jsand/assets/mermaid.jswere being wrapped in the HTML page shell by the redirect middleware, causing JS parse errorsTwo-line fix in
mod.rs.Test plan
rivet serve→ no console errors, HTMX navigation works, fonts load🤖 Generated with Claude Code