Skip to content

ci: key main concurrency group per-sha so main runs stay conclusive (#436) #481

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
Jun 5, 2026
Merged

ci: key main concurrency group per-sha so main runs stay conclusive (#436) #481

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/benchmarks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,10 @@
name: Benchmarks

# Cancel superseded PR runs; protect main + scheduled runs.
# Cancel superseded PR runs; keep every main commit's run conclusive.
# On push the group falls back to `github.sha` (not `github.ref`) so a later
# main push never supersedes an earlier main run (incl. queued ones) — #436.
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
group: ${{ github.workflow }}-${{ github.head_ref || github.sha }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

on:
Expand Down
11 changes: 8 additions & 3 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,14 @@
name: CI

# Cancel superseded PR runs; protect main + scheduled runs.
# `head_ref || ref` keys per-PR-source-branch on PRs, falls back to ref on push.
# Cancel superseded PR runs; keep every main commit's run conclusive.
# On PRs, `head_ref` groups per source branch so cancel-in-progress supersedes
# stale runs. On push, the fallback is `github.sha` (NOT `github.ref`): keying
# every main commit to its own group means a later push never supersedes an
# earlier main run — even queued ones (#436). With a shared `refs/heads/main`
# group, rapid merges left main's runs `cancelled` and Playwright never reached
# a conclusive result, hiding real regressions.
concurrency:
group: ${{ github.workflow }}-${{ github.head_ref || github.ref }}
group: ${{ github.workflow }}-${{ github.head_ref || github.sha }}
cancel-in-progress: ${{ github.event_name == 'pull_request' }}

on:
Expand Down
Loading