ci(nextest): retry flaky tests so one serve-test race doesn't red main (closes #493)#494
Merged
Conversation
closes #493) Main's Test gate flaked red on commit 00876df (additive dashboard HTML) while the code was sound — `cargo test --workspace` and `cargo nextest run --all --profile ci` both pass locally (2075/2075). Root cause: the ci nextest profile had `fail-fast = false` but no `retries`, so one flaky serve/integration test (port/timing race under CI parallelism) fails the whole gate. The repo has band-aided this per-test three times already. Add `retries = 2` to [profile.ci]: a test that passes on retry is reported FLAKY (visible in the summary + JUnit) instead of failing the gate and reddening main; a genuinely-broken test still fails after all retries, so real regressions aren't hidden. Confirmed with: cargo nextest list --profile ci (config parses); cargo nextest run --all --profile ci → 2075 passed / 0 failed.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: b149c5c | Previous: 00876df | Ratio |
|---|---|---|---|
link_graph_build/10000 |
34731651 ns/iter (± 3764618) |
27865661 ns/iter (± 2885826) |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #493. Fixes the recurring flaky-
Test-gate friction at the systemic level.Why
Main's
Testgate went red on commit00876df(REQ-207, additive dashboard HTML), but the code is sound:cargo test --workspace→ all pass, 0 failedcargo nextest run --all --profile ci(the exact CI command) → 2075 passed / 0 failedserve_integration→ 43/43→ a flake (a serve/integration test racing on a port/timing under CI parallelism). The ci nextest profile had
fail-fast = falsebut noretries, so a single flaky failure reds the whole gate. The repo has already band-aided this per-test three times (server_pages_push_url, test_reload_yaml_error, #331).Fix
retries = 2on[profile.ci]. A test passing on retry → reported FLAKY (visible, in the JUnit too); a genuinely-broken test → still fails after all retries. Absorbs races without hiding regressions. Standard nextest practice.Verification
cargo nextest list --profile ci(config parses) ·cargo nextest run --all --profile ci→ 2075 passed / 0 failed. CI-only config; no product code.🤖 Generated with Claude Code