feat(build): remove embed-wasm feature gate — build.rs generates stubs#50
Merged
feat(build): remove embed-wasm feature gate — build.rs generates stubs#50
Conversation
WASM assets are now always compiled into the binary: - build.rs generates stub files when spar WASM is not built, so include_str!/include_bytes! always succeeds - Stub JS is detected at runtime (starts with "// stub") and returns 404, so the client-side HEAD probe works correctly - When spar repo is found, build.rs checks out the pinned Cargo.toml rev before building WASM to ensure version consistency - Removed embed-wasm feature from Cargo.toml — no more --features flag Implements: FEAT-064 Refs: REQ-022 Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: a91cfb8 | Previous: fd6075b | Ratio |
|---|---|---|---|
query/10000 |
154604 ns/iter (± 389) |
107075 ns/iter (± 671) |
1.44 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
--features embed-wasmis gone — WASM is always embeddedTest plan
🤖 Generated with Claude Code