Merged
Conversation
Print layout was missing mermaid.js script tag — diagrams didn't render. Also fixed /?print=1 to use print_layout middleware for root path. Added 4 new print-specific Playwright tests: - mermaid.js script present in print view - mermaid library loads successfully - print layout has no sidebar nav - print view shows "printed view" footer 218/218 Playwright tests pass. Fixes: FEAT-001 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 369c031 | Previous: 2e062f4 | Ratio |
|---|---|---|---|
traceability_matrix/1000 |
59240 ns/iter (± 226) |
45417 ns/iter (± 529) |
1.30 |
query/10000 |
119272 ns/iter (± 1147) |
92142 ns/iter (± 512) |
1.29 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mermaid.js added to print layout. 218/218 Playwright pass.
🤖 Generated with Claude Code