feat: LSP foundation, baseline-scoped validation, 7.8x perf fix#58
Merged
feat: LSP foundation, baseline-scoped validation, 7.8x perf fix#58
Conversation
Three workstreams: 1. LSP foundation (rivet lsp): - lsp-server + lsp-types dependencies - Lsp subcommand with stdio connection - Server capabilities: text sync, diagnostics, hover, goto-def, completion - Main message loop with shutdown handling - Foundation for incremental validation via salsa 2. Baseline-scoped validation (--baseline flag): - BaselineConfig in rivet.yaml (ordered, cumulative) - Artifact.baseline() helper reads from fields map - Store::scoped() filters by baseline (cumulative inclusion) - --baseline flag on validate, list, stats, coverage, export - Dogfood: v0.1.0 (53 artifacts) and v0.2.0-dev baselines defined - REQ/DD/FEAT artifacts tagged with baseline fields 3. Performance fixes (7.8x store speedup): - O(n²) Store::upsert fixed (linear contains → direct insert) - Regex pre-compilation for conditional rules (N×M → M compiles) - Cow<str> for get_field_value (zero-copy field reads) - Allocation-free allowed_values check - Hoisted forward-map entry in LinkGraph::build - Cached diagnostics in AppState (no re-validation per page view) Implements: FEAT-047 Satisfies: REQ-029 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Codecov Report❌ Patch coverage is
📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
rivet lspsubcommand foundation (lsp-server + lsp-types, stdio, capabilities)--baseline v0.1.0flag on validate/list/stats/coverage/exportTest plan
rivet validatePASSrivet stats --baseline v0.1.0→ 53 artifacts🤖 Generated with Claude Code