feat(serve): artifact detail renders a Test Result Trace panel (REQ-238, #547)#654
Merged
Conversation
…38, #547) Completes the graphical half of REQ-238. The forward-trace mechanism (rivet-core result_trace + `rivet trace-results`) shipped in #645; this adds the dashboard counterpart the issue asked for. The artifact detail view now walks forward from the artifact to the verifications/tests that trace back to it, rolls the reached test results into a one-line verdict badge (passing / failing / no test evidence), and lists each reached node with its hop distance, link type, and latest result. The panel renders only when something traces back, so leaf artifacts stay clean. Depth 4 mirrors the CLI default (the ASPICE V depth). Reached-node ids link to their own detail view for drill-down. Confirmed with a live server: /artifacts/REQ-001 renders the panel with a "passing" verdict and the reached-node table; leaf artifacts omit it. Full serve_integration suite (48/48), cargo clippy --all-targets -- -D warnings, and cargo fmt --check all green. Implements: REQ-238 Verifies: REQ-238 Refs: FEAT-001
📐 Rivet artifact delta
Graphgraph LR
REQ_238["REQ-238"]:::modified
classDef added fill:#d4edda,stroke:#28a745,color:#155724
classDef removed fill:#f8d7da,stroke:#dc3545,color:#721c24
classDef modified fill:#fff3cd,stroke:#ffc107,color:#856404
classDef overflow fill:#e2e3e5,stroke:#6c757d,color:#495057,stroke-dasharray: 3 3
Modified
Posted by |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: a780189 | Previous: ce754d3 | Ratio |
|---|---|---|---|
link_graph_build/10000 |
57920371 ns/iter (± 5136365) |
25040374 ns/iter (± 2068891) |
2.31 |
diff/10000 |
10676934 ns/iter (± 1027650) |
7866729 ns/iter (± 368338) |
1.36 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Completes REQ-238 (
#547): the dashboard now has a graphical way to trace a requirement to its test results. The forward-trace mechanism (rivet-coreresult_trace+rivet trace-results) shipped in #645; this adds the dashboard counterpart the issue asked for.The artifact detail view walks forward from the artifact to the verifications/tests that trace back to it, rolls the reached test results into a one-line verdict badge (
passing/failing/no test evidence), and lists each reached node with its hop distance, link type, and latest result. Reached-node ids link to their own detail view for drill-down.Behavior
passing(all recorded results passed, ≥1 recorded),failing(any fail/error),no test evidence(no reached result recorded).Verification
serve_integrationtestartifact_detail_renders_test_result_traceasserts the panel, verdict badge, and Hops/Via table render forREQ-001./artifacts/REQ-001shows apassingverdict and the reached-node table; leaf artifacts omit the panel.serve_integrationsuite 48/48;cargo clippy --all-targets -- -D warningsexit 0;cargo fmt --checkclean;rivet validatePASS.Traceability
verified)🤖 Generated with Claude Code