fix(vscode): browser dashboard instead of iframe#75
Merged
Conversation
VS Code WebViews can't access localhost (sandbox blocks local-network). Changed dashboard commands to open in the default browser via vscode.env.openExternal. The LSP still runs in-editor for diagnostics, hover, goto-def, and completions. Trace: skip
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: cf2b32d | Previous: b8030f1 | Ratio |
|---|---|---|---|
store_lookup/100 |
2175 ns/iter (± 12) |
1689 ns/iter (± 4) |
1.29 |
store_lookup/1000 |
26788 ns/iter (± 171) |
19265 ns/iter (± 34) |
1.39 |
traceability_matrix/1000 |
59036 ns/iter (± 415) |
42087 ns/iter (± 175) |
1.40 |
query/100 |
793 ns/iter (± 2) |
633 ns/iter (± 2) |
1.25 |
query/1000 |
7297 ns/iter (± 31) |
5143 ns/iter (± 12) |
1.42 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WebView can't access localhost. Opens in browser instead. LSP stays in-editor. 🤖