fix(vscode): SSH Remote + LSP error handling#77
Merged
Conversation
- Platform-aware binary lookup (bin/{platform}-{arch}/rivet)
- Falls back to PATH when bundled binary doesn't match remote arch
- client.stop() errors caught (prevents crash loop on startFailed)
- deactivate() handles already-stopped client
For SSH Remote: install rivet on the remote host via cargo install rivet-cli
Trace: skip
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 88b8921 | Previous: 0551da4 | Ratio |
|---|---|---|---|
store_insert/10000 |
14340055 ns/iter (± 1296719) |
11831545 ns/iter (± 830080) |
1.21 |
link_graph_build/10000 |
34210792 ns/iter (± 3264835) |
26881969 ns/iter (± 1282012) |
1.27 |
validate/100 |
41033 ns/iter (± 160) |
33294 ns/iter (± 130) |
1.23 |
validate/10000 |
6467414 ns/iter (± 757525) |
4862451 ns/iter (± 241503) |
1.33 |
diff/10000 |
9735520 ns/iter (± 947037) |
7818228 ns/iter (± 184794) |
1.25 |
This comment was automatically generated by workflow using github-action-benchmark.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Platform-aware binary lookup, graceful LSP failure. 🤖