Skip to content

fix(vscode): LSP cwd + error diagnostics #78

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
avrabe merged 1 commit into from
Mar 22, 2026
Merged

fix(vscode): LSP cwd + error diagnostics #78

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion vscode-rivet/src/extension.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,11 +44,13 @@ export async function activate(context: vscode.ExtensionContext) {
return;
}

const lspWorkspaceRoot = vscode.workspace.workspaceFolders?.[0]?.uri.fsPath;
try {
const serverOptions: ServerOptions = {
command: rivetPath,
args: ['lsp'],
transport: TransportKind.stdio,
options: { cwd: lspWorkspaceRoot },
};

const clientOptions: LanguageClientOptions = {
Expand All @@ -70,10 +72,13 @@ export async function activate(context: vscode.ExtensionContext) {
});

statusBarItem.text = '$(shield) Rivet';
console.log(`rivet LSP started: ${rivetPath}`);
} catch (err: unknown) {
const msg = err instanceof Error ? err.message : String(err);
vscode.window.showWarningMessage(`Rivet LSP failed to start: ${msg}`);
vscode.window.showWarningMessage(`Rivet LSP failed to start (${rivetPath}): ${msg}`);
statusBarItem.text = '$(shield) Rivet (LSP error)';
console.error(`rivet LSP error: ${msg}, binary: ${rivetPath}, cwd: ${lspWorkspaceRoot}`);
// Continue without LSP — serve and commands still work
}

// --- Start serve --watch in background ---
Expand Down
Loading