fix: /embed/* path prefix for sidebar-free VS Code WebView#83
Merged
Conversation
The middleware now strips /embed prefix from the URI path before routing, so /embed/stats → embed_layout(stats_view), /embed/stpa → embed_layout(stpa_view). No route duplication needed — same handlers, different layout wrapping. This avoids the ?embed=1 query param which VS Code's asExternalUri URL-encodes to ?embed%3D1, breaking the middleware detection. Verified: /embed/stats returns 0 <nav> elements, /stats returns 1. Also fixes CSP frame-src to use origin-only (no path+query). Fixes: FEAT-057
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
⚠️ Performance Alert ⚠️
Possible performance regression was detected for benchmark 'Rivet Criterion Benchmarks'.
Benchmark result of this commit is worse than the previous benchmark result exceeding threshold 1.20.
| Benchmark suite | Current: 94febb5 | Previous: 8902362 | Ratio |
|---|---|---|---|
link_graph_build/10000 |
34180617 ns/iter (± 2126382) |
28024491 ns/iter (± 2183624) |
1.22 |
diff/10000 |
10808254 ns/iter (± 474707) |
8174208 ns/iter (± 347212) |
1.32 |
This comment was automatically generated by workflow using github-action-benchmark.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Strips /embed from path, uses embed_layout. Verified: 0 nav in embed, 1 in normal. 🤖