Conversation
…kip_rekor Three improvements from STPA-Sec implementation plan Phase 1: 1. Replace magic string "skipped" with REKOR_SKIPPED_UUID constant and is_rekor_skipped() helper function. Eliminates fragile string coupling between signer and verifier. 2. Add loud warning when OIDC issuer validation is not configured (log::warn with guidance to set --expected-issuer). Add URL normalization for trailing slash comparison to prevent false rejections. 3. Emit log::error + stderr banner when skip_rekor=true, explicitly stating the module cannot pass keyless verification. Updated doc comments to reflect DD-2 fail-closed incompatibility. Fixes: SC-5 Refs: AS-6, AS-13, DD-2, UCA-12 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Phase 1 of the STPA-Sec implementation plan — immediate security hardening of shipped code.
1.1 Replace magic string sentinel with constant
REKOR_SKIPPED_UUIDconstant andis_rekor_skipped()helper inrekor.rs1.2 OIDC issuer validation improvements
log::warn!emitted when no--expected-issuerorWSC_EXPECTED_OIDC_ISSUERis set, with guidancehttps://accounts.google.comvshttps://accounts.google.com/)1.3 Loud skip_rekor warning
log::error!+ stderr banner whenskip_rekor=true: "this module cannot pass keyless verification"REKOR_SKIPPED_UUIDconstant instead of inline stringTest plan
cargo test— 591 tests pass🤖 Generated with Claude Code