docs: align AADL version claims with actual support (v2.3 / AS5506D)#134
Merged
docs: align AADL version claims with actual support (v2.3 / AS5506D)#134
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
Spar has grown beyond AADL v2.2. The crate parses/analyzes/solves against SAE AS5506D (AADL v2.3) — arrays, prototypes, modal filtering, enhanced property expressions are all in the grammar and tested. The docs had drifted: - README.md subtitle: `AADL v2.2/v2.3` → `AADL v2.3` (v2.3 is a superset; no information lost) - README.md badge: `AADL_v2.2-AS5506D` → `AADL_v2.3-AS5506D` (v2.2 + AS5506D was internally contradictory; AS5506D covers v2.3) - docs/introduction.md: title + crate table + Key Features bullet updated from v2.2/AS5506C to v2.3/AS5506D, with a note that v2.2 models remain accepted. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
The two `write_model()` callers shared a single tmp path keyed only on `process::id()`. Cargo runs tests in parallel within one process, so both tests landed on the same path and one's `fs::remove_file` could race the other's `spar instance` invocation. Surfaced as a flaky Proptest (extended) failure on PR #134. Add a per-test `tag` argument so each test gets a unique path. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
force-pushed
the
docs/aadl-v23-description
branch
from
3610dc2 to
3ce6013
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Spar has grown beyond AADL v2.2. The crate parses, analyzes, and solves against SAE AS5506D (AADL v2.3) — arrays, prototypes, modal filtering, enhanced property expressions are all in the grammar and tested. The public docs had drifted:
README.mdsubtitle:AADL v2.2/v2.3→AADL v2.3(v2.3 is a superset of v2.2, no information lost).README.mdbadge:AADL_v2.2-AS5506D→AADL_v2.3-AS5506D. v2.2 + AS5506D was internally contradictory — AS5506D is the 2024 revision covering AADL v2.3.docs/introduction.md: title, crate table (spar-parser), and "Key Features" bullet updated from v2.2 / AS5506C to v2.3 / AS5506D. Note added that v2.2 models remain accepted.Test plan
Docs-only; CI should be green (no code touched).
🤖 Generated with Claude Code