feat: criterion benchmarks for scheduling solver + codegen (#137)#143
Merged
feat: criterion benchmarks for scheduling solver + codegen (#137)#143
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
avrabe
added a commit
that referenced
this pull request
Apr 23, 2026
cargo-vet flagged 31 transitive dev-dependencies pulled in by criterion 0.5 (clap, plotters, wasm-bindgen, ciborium, etc.) as unvetted. Added as safe-to-run exemptions — these crates are dev- only via benches/ and never ship in the production artifact. The 'safe-to-run' criteria reflects that: the code may execute on the developer machine but will never enter a deployed binary. This matches how the existing 'bit-set', 'bit-vec' dev-dep exemptions are classified. Resolves the Supply Chain (cargo-vet) CI failure on #143. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
added a commit
that referenced
this pull request
Apr 24, 2026
cargo-vet flagged 31 transitive dev-dependencies pulled in by criterion 0.5 (clap, plotters, wasm-bindgen, ciborium, etc.) as unvetted. Added as safe-to-run exemptions — these crates are dev- only via benches/ and never ship in the production artifact. The 'safe-to-run' criteria reflects that: the code may execute on the developer machine but will never enter a deployed binary. This matches how the existing 'bit-set', 'bit-vec' dev-dep exemptions are classified. Resolves the Supply Chain (cargo-vet) CI failure on #143. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
force-pushed
the
fix/137-criterion-benchmarks
branch
from
733ebfe to
e4e326f
Compare
avrabe
added a commit
that referenced
this pull request
Apr 24, 2026
cargo-vet flagged 31 transitive dev-dependencies pulled in by criterion 0.5 (clap, plotters, wasm-bindgen, ciborium, etc.) as unvetted. Added as safe-to-run exemptions — these crates are dev- only via benches/ and never ship in the production artifact. The 'safe-to-run' criteria reflects that: the code may execute on the developer machine but will never enter a deployed binary. This matches how the existing 'bit-set', 'bit-vec' dev-dep exemptions are classified. Resolves the Supply Chain (cargo-vet) CI failure on #143. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
force-pushed
the
fix/137-criterion-benchmarks
branch
from
e4e326f to
ed6788a
Compare
Adds `benches/` to spar-solver and spar-codegen with criterion harnesses plus CI plumbing to gate compilation and collect nightly baselines. spar-solver groups: - small (<=8 tasks, RM-feasible utilization) - medium (<=64 tasks, representative avionics workload) - large (<=256 tasks, sample_size=10 to keep runtime sane) - worst_case (utilization ~0.95 schedulability boundary) spar-codegen group: schedule emission for 64-task workload. CI: - `bench-smoke` in ci.yml: `cargo bench --no-run` on PRs (compile gate) - `bench-nightly.yml`: cron daily 03:30 UTC, saves baseline, uploads target/criterion/ Traceability in `artifacts/verification.yaml`: bench entries linked to existing REQ-SOLVER-* and REQ-CODEGEN-* requirements. Closes #137. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
force-pushed
the
fix/137-criterion-benchmarks
branch
from
ed6788a to
e4468a2
Compare
avrabe
added a commit
that referenced
this pull request
Apr 24, 2026
cargo-vet flagged 31 transitive dev-dependencies pulled in by criterion 0.5 (clap, plotters, wasm-bindgen, ciborium, etc.) as unvetted. Added as safe-to-run exemptions — these crates are dev- only via benches/ and never ship in the production artifact. The 'safe-to-run' criteria reflects that: the code may execute on the developer machine but will never enter a deployed binary. This matches how the existing 'bit-set', 'bit-vec' dev-dep exemptions are classified. Resolves the Supply Chain (cargo-vet) CI failure on #143. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
cargo-vet flagged 31 transitive dev-dependencies pulled in by criterion 0.5 (clap, plotters, wasm-bindgen, ciborium, etc.) as unvetted. Added as safe-to-run exemptions — these crates are dev- only via benches/ and never ship in the production artifact. The 'safe-to-run' criteria reflects that: the code may execute on the developer machine but will never enter a deployed binary. This matches how the existing 'bit-set', 'bit-vec' dev-dep exemptions are classified. Resolves the Supply Chain (cargo-vet) CI failure on #143. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
avrabe
force-pushed
the
fix/137-criterion-benchmarks
branch
from
e4468a2 to
170760f
Compare
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
spar-solver(small/medium/large/worst-case) andspar-codegenbench-smoke(PR compile gate) +bench-nightly.yml(cron, saves baseline)artifacts/verification.yamlBench groups
spar-solver/benches/solver_benchmarks.rssolver_smallsolver_mediumsolver_largesample_size(10)to bound runtimesolver_worst_casespar-codegen/benches/codegen_benchmarks.rs— emit-to-string for 64 tasks.CI strategy
PR gate is compile-only (
--no-run) — fast and catches regressions in bench code itself. Nightly collects timing baselines and uploadstarget/criterion/as artifact. No regression-fail gate yet — gathering data first.Test plan
bench-smokeCI job passescargo build --workspace --benchesclean locally for reviewer🤖 Generated with Claude Code