chore(verify-gate): revert TEST-PROOF-* steps to lake build (ELAN_HOME now on runners)#227
Merged
Merged
Conversation
…runners have ELAN_HOME PR #223 landed a sorry-grep + file-exists workaround for TEST-PROOF-LATENCY and TEST-PROOF-ARINC653 because the smithy runners didn't have Lean on PATH for the rivet verification gate. Smithy's been since fixed (commit dfb0eed): `ELAN_HOME=/home/ralf/.elan` is now in every runner's env, ProtectHome=read-only protects ralf's shared elan state, and `lake --version` confirmed working on all 12 runners with Lean 4.29.0-rc6 + Lake 5.0.0-src. Reverts the workaround to the proper `cd proofs && lake build` step. The full Lean typecheck now runs inside the verification gate, not just as a sorry-free smoke. The dedicated "Lean proof typecheck (lake build)" CI workflow remains as defense-in-depth. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This was referenced May 18, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reverts the sorry-grep workaround introduced in #223 now that smithy runners have Lean toolchain access.
Background
PR #223 introduced two Lean proofs (
Latency.lean,Arinc653Isolation.lean) with verification artifacts that intended to run `cd proofs && lake build`. But the rivet verification gate runs on `[self-hosted, linux, x64, rust-cpu]` runners which did not have Lean on PATH, so the gate failed.The workaround was to substitute:
```yaml
steps:
```
— a file-exists + sorry-free smoke check. Functional but not full type-checking.
Smithy fix landed
Smithy commit `dfb0eed`: `ELAN_HOME=/home/ralf/.elan` set in runner env, `ProtectHome=read-only` keeps ralf's shared elan state safe, all 12 runners verified with `lake --version` → Lake 5.0.0-src + Lean 4.29.0-rc6.
What this PR does
Restores the two TEST-PROOF-* artifacts to use `cd proofs && lake build` as their verification step:
```yaml
steps:
```
The rivet verification gate now runs full Lean typechecking inline, not just a sorry-free smoke. The dedicated "Lean proof typecheck (lake build)" CI workflow remains as defense-in-depth.
Test plan
Co-Authored-By: Claude Opus 4.7 noreply@anthropic.com