fix(release): cargo-cyclonedx uses --manifest-path, not cargo's -p#138
Merged
Conversation
The v0.6.0 release pipeline failed at the toolchain-SBOM step: 'cargo cyclonedx -p synth-cli' exited with 'unexpected argument -p'. cargo-cyclonedx is a cargo subcommand but does not proxy cargo's package-selection flag; the correct way to target a single workspace crate is '--manifest-path crates/synth-cli/Cargo.toml'.
Codecov Report✅ All modified and coverable lines are covered by tests. 📢 Thoughts on this report? Let us know! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v0.6.0's release pipeline failed at the toolchain-SBOM step:
cargo-cyclonedxis a cargo subcommand but does not proxy cargo's package-selection flag. The correct way to target a single workspace crate is--manifest-path crates/synth-cli/Cargo.toml. Patch swaps-p synth-clifor that.All 4 binary builds (v0.6.0 run 26366062176) succeeded; only
Create GitHub Releasefailed at this step, so no v0.6.0 GitHub Release was created (only the git tag exists). Plan: merge this → delete + re-push the v0.6.0 tag against the fixed commit → release pipeline runs cleanly.The PR #136 agent's command was a reasonable assumption (cargo subcommands often proxy
-p); the clean-room verification confirmed the workflow file matched the agent's claim but didn't run the command. Real validation only happened at release time — which is the gating-fuzz-class pattern, just at release granularity.🤖 Generated with Claude Code